fix(concordance): include CSEC2017 in Frameworks listing table#2
Merged
Conversation
The Frameworks listing used `contents: "*-*.qmd"`, which requires a hyphen in the filename. csec2017.qmd has no hyphen, so it never matched the glob and was silently omitted from the rendered table even though the page itself exists and renders. Broaden the listing glob to also match the no-hyphen file rather than renaming the page. The `csec2017` slug (no hyphen) is the established convention across the corpus — the framework_summary slug is `csec2017-v1`, the ingest script is `010-ingest-csec2017.R`, and the alignment data/query files are all `nice_csec2017_*`. Renaming the page would make it the lone divergent spelling and churn the query, homepage, and use-case links. The Frameworks table now shows all eight frameworks, including CSEC2017 (Global / Pedagogy / 8 units / 40 elements). This matters because the ISCAP 2026 Concordance paper describes the Frameworks page as part of the instrument; a framework missing from its own corpus table is a visible defect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
One line in
concordance/frameworks/index.qmd:Why
The Frameworks listing used a Quarto glob (
*-*.qmd) that requires a hyphen in the filename. The CSEC2017 page is namedcsec2017.qmd(no hyphen), so it never matched the glob and was silently omitted from the rendered Frameworks table — even though the page itself exists and renders fine. The other seven framework pages (nice-v2,dcwf-v51,ecsf-v1,sfia-9,digcomp-22,csta-2017,cyberorg-k12) all have hyphens.This matters because the ISCAP 2026 Concordance paper describes the Frameworks page as part of the instrument. A framework missing from its own corpus table is a visible defect.
Why broaden the glob instead of renaming the file
The
csec2017slug (no hyphen) is the established convention across the whole corpus:framework_summaryslug iscsec2017-v1010-ingest-csec2017.Rnice_csec2017_*Renaming the page to
csec-2017.qmdwould make it the lone divergent spelling and churn the alignment query, homepage cards/links, and the curriculum-coordinator use-case. The glob broadening is a one-line change that leaves the naming convention intact.Effect
csec2017.qmddoes not match*-*.qmd, so it is added exactly once.Verification
Rebuilt
frameworks/index.qmd; the rendered_site/frameworks/index.htmlnow contains "ACM/IEEE CSEC2017" and links to all eight framework pages.Reviewer note
This list-based
contentsretains the same latent trap for the next no-hyphen framework filename. A more durable pattern would becontents: "*.qmd"(the index page excludes itself automatically), but that is a larger change and out of scope here.